nextcloud / nextcloud/contacts

Backslashes (Escaped slashes) in URL's on imports from google

Open
#2,734 3 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

0. Needs triage enhancement feature: contacts feature: import
Dominant language
JavaScript
Stars
642
Forks
220
Avg merge
14h 39m
Merged PRs (30d)
51

Description

Describe the bug

I'd import my addresslist from Google.
On Google I've exported it as VCARD :
image

If I import those vcs file into nextcloud/contacts, all / are escaped:
image

If I look into the vcs, I see, that slashes are also escaped there, but only once:
image

It would be nice, if contact could recognize such escape characters, and remove them

Steps to reproduce
  1. Create an address entry with an http://xyz.com in your google contacts
  2. Export an addressbook as VCS from Google
  3. Import it to nextcloud contacts
  4. see error in contacts address entry
Expected behavior

slashes should not be escaped in contacts

Actual behavior

slashes are escaped

Contact version

4.1.0

Operating system

didn't found.. as it's a managed one by hetzner. BTW, isn't there a way to see that in nextcloud gui?

PHP engine version

No response

Web server

No response

Database

No response

Operating system

No response

List of activated Apps
Can't run this command. 
I do have an managed service on Hetnzer: https://www.hetzner.com/storage/storage-share?country=de
So I don't have access to the server below.

Couldn't you create such an URL to output those list like the following section "Nextcloud Signing status"?: https://yournextcloud.tld/index.php/settings/integrity/failed

That would make things easier for bugreporters.
Nextcloud Signing status
No errors have been found.
Configuration report
Same here as above, no access to cli.
Additional info

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

The issue names no source file or test. Start by reproducing a Google VCS import containing an http:// URL, then trace how the imported contact value is parsed; done means URL slashes remain unescaped in the contact address.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.