nextcloud / nextcloud/contacts

why is not using inputs.scss => Line 800 P:a !i; to have z-index: 2; use

Open
#2,694 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug feature: contacts skill:frontend
Dominant language
JavaScript
Stars
642
Forks
220
Avg merge
14h 39m
Merged PRs (30d)
51

Description

Describe the bug

Hi,

i play around at moment with my customised skin in /themes

and there is my notized, there is a small bug in the css..
because there is used webpack://./index.scss:5 in
app-contacts .multiselect .multiselect__tags input.multiselect__input
with "position:relative !important"
and not absolute !important like it is in the inputs.scss at line 800
how must be used, because the z-indexes.. therewith
moves via flex to minimal size and outside leftsided of the "mobil,home,voice a.s.o."
as small button and moves the whole "headbutton" to right side..
i have check out in firefox the whole with the "investigate" in the right mouse menu on these button/selector
and have change the css entry to "absolute" under
".multiselect[*] .multiselect__tags input.multiselect__input"
and look, the button is, like it must be.. so.. there is also n bug.. because
everywhere is setting up "important" with "relative" although if need "absolut" for setting up z-index .
:\

so, then i'll report this here as bug... in css.

best
Blacky

Steps to reproduce
  1. Go to 'contacts = Phoneentry, look the button where can you select Private/work
  2. take portable firefox and Click on ' investigate at the button, look on the css-code'
  3. Scroll down to
.multiselect[data-v-*]      index.scss:5
 .multiselect__tags input.multiselect__input {
  width: 100% !important;
  position: relative !important;  /*<= change this to "absolute"*/
  margin: 0;
  opacity: 0;
  height: 100% !important;
  border: none;
  cursor: pointer;
  padding: 7px 6px !important;
  display: none;
}
  1. the button is correctly sized

Pictures:

Screen 00000
Screen 00001
Screen 00002
Screen 00003
Screen 00004
Screen 00005
Screen 00006
Screen 00007
Screen 00008
Screen 00009

Expected behavior

^look on top

Actual behavior

use not the righ css entry,
where is the multiselect__input buttons wrong sized

Contact version

22.2

Operating system

Fedora

PHP engine version

PHP 8.0

Web server

No response

Database

MariaDB

Operating system

Fedora 35

List of activated Apps
Sun Mar 27 15:14:21 2022 from 192.168.0.2
[blackcrack@blackysgate ~]$ mcedit /srv/nextcloud/
3rdparty/     AUTHORS       console.php   core/         .htaccess     index.php     occ           ocs/          public.php    resources/    status.php    updater/      version.php   
apps/         config/       COPYING       cron.php      index.html    lib/          ocm-provider/ ocs-provider/ remote.php    robots.txt    themes/       .user.ini     
[blackcrack@blackysgate ~]$ mcedit /srv/nextcloud/core/css/inputs.scss

[blackcrack@blackysgate ~]$ sudo -u www-data php occ app:list
sudo: Unbekannter Benutzer: www-data
sudo: Audit-Plugin sudoers_audit konnte nicht initialisiert werden
[blackcrack@blackysgate ~]$ cd /srv/nextcloud
[blackcrack@blackysgate /srv/nextcloud]$ sudo -u apache php occ app:list
[sudo] Passwort für blackcrack: 
Enabled:
  - accessibility: 1.8.0
  - activity: 2.15.0
  - announcementcenter: 6.1.1
  - apporder: 0.14.0
  - audioplayer: 3.2.4
  - bookmarks: 10.1.0
  - bruteforcesettings: 2.3.0
  - calendar: 3.2.2
  - checksum: 1.1.3
  - circles: 22.2.0
  - cloud_federation_api: 1.5.0
  - comments: 1.12.0
  - contacts: 4.1.0
  - contactsinteraction: 1.3.0
  - cpanelmailsync: 0.1.7
  - customproperties: 2.0.4
  - dav: 1.20.0
  - duplicatefinder: 0.0.13
  - emlviewer: 1.0.1
  - epubreader: 1.4.7
  - event_update_notification: 1.4.0
  - external: 3.9.0
  - extract: 1.3.3
  - federatedfilesharing: 1.12.0
  - federation: 1.12.0
  - files: 1.17.0
  - files_3d: 0.5.0
  - files_antivirus: 3.2.2
  - files_external: 1.13.1
  - files_linkeditor: 1.1.9
  - files_markdown: 2.3.5
  - files_mindmap: 0.0.26
  - files_pdfviewer: 2.3.1
  - files_rightclick: 1.1.0
  - files_sharing: 1.14.0
  - files_texteditor: 2.14.0
  - files_trackdownloads: 1.11.0
  - files_trashbin: 1.12.0
  - files_versions: 1.15.0
  - files_videoplayer: 1.11.0
  - firstrunwizard: 2.11.0
  - groupfolders: 10.0.2
  - logreader: 2.7.0
  - lookup_server_connector: 1.10.0
  - mail: 1.11.7
  - maps: 0.1.10
  - metadata: 0.15.0
  - music: 1.5.1
  - ncdownloader: 0.9.0
  - news: 18.0.0
  - nextcloud_announcements: 1.11.0
  - notes: 4.3.1
  - notifications: 2.10.1
  - oauth2: 1.10.0
  - occweb: 0.1.0
  - ocdownloader: 1.8.0
  - password_policy: 1.12.0
  - photos: 1.4.0
  - privacy: 1.6.0
  - provisioning_api: 1.12.0
  - quicknotes: 0.7.3
  - radio: 1.0.3
  - recommendations: 1.1.0
  - rocketchat_nextcloud: 0.9.6
  - serverinfo: 1.12.0
  - settings: 1.4.0
  - sharebymail: 1.12.0
  - shifts: 1.8.6
  - side_menu: 2.3.4
  - socialsharing_email: 2.4.0
  - spreed: 12.2.4
  - support: 1.5.0
  - survey_client: 1.10.0
  - systemtags: 1.12.0
  - tasks: 0.14.4
  - text: 3.3.0
  - twofactor_backupcodes: 1.11.0
  - updatenotification: 1.12.0
  - user_status: 1.2.0
  - video_converter: 1.0.4
  - viewer: 1.6.0
  - weather_status: 1.2.0
  - workflow_pdf_converter: 1.7.0
  - workflowengine: 2.4.0
Disabled:
  - admin_audit
  - audioplayer_editor: 0.3.0
  - dashboard: 7.0.0
  - encryption
  - printer: 0.0.5
  - theming: 1.9.0
  - theming_customcss: 1.10.0
  - user_ldap
[blackcrack@blackysgate /srv/nextcloud]$
Nextcloud Signing status
No errors have been found.
Configuration report
e
Additional info

nope

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with core/css/inputs.scss around line 800 and reproduce the Contacts Phoneentry selector in Firefox. Compare the source rule with the generated index.scss rule for .multiselect__tags input.multiselect__input; done means the selector uses the intended positioning and the contact-type button keeps its correct size and placement.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, scss
Domain
frontend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.