nextcloud / nextcloud/contacts

disabled contact birthdays displayed

Open
#2,593 1 comment 4 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

0. Needs triage feature: contacts
Dominant language
JavaScript
Stars
642
Forks
220
Avg merge
14h 39m
Merged PRs (30d)
51

Description

Describe the bug

Disabled address books contacts show up in "Contact birthdays" calendar.

To Reproduce
Steps to reproduce the behaviour:

  1. Go to /apps/contacts/
  2. Create address book
  3. Add new contact with birthday, anniversary, etc. to new address book
  4. Disable address book
  5. Note that new contact is not discoverable in the ui
  6. Sync /remote.php/dav/calendars/:user/contact_birthdays/
  7. See contact birthday in Contact birthdays calendar

Expected behavior
I would expect disabling an address book hides all data contained within from other applications within nextcloud.

Actual behavior
Tell us what happened instead.

Screenshots
Available upon request.

Server configuration

Operating system: Linux

Web server: Any

Database: Any

PHP version: Several

Nextcloud version: Several

Contacts version: Several

Updated from an older Nextcloud or fresh install: Either

Signing status:

No errors have been found.

List of activated apps:
Available upon request.

Nextcloud configuration:
Available upon request.

Client configuration

Browser: Many

Operating system: All

CardDAV-clients: Multiple

Logs
Web server error log

Available upon request.

Nextcloud log
data/nextcloud.log

Available upon request.

Browser log

Available upon request.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the /remote.php/dav/calendars/:user/contact_birthdays/ endpoint and trace how disabled address books are filtered when contact birthdays are generated. Reproduce the issue with a disabled address book containing a birthday, then verify that its data is absent from the Contact birthdays calendar while enabled address books still appear.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
api, backend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.