nextcloud / nextcloud/contacts

Renaming a shared address book doesn't work

Open
#2,502 3 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

0. Needs triage feature: contacts
Dominant language
JavaScript
Stars
642
Forks
220
Avg merge
14h 39m
Merged PRs (30d)
51

Description

Describe the bug

I want to rename an address book that was shared to my user (directly or via group) but cannot. Instead I get an "rename was unsuccessful" error popup.

To Reproduce
Steps to reproduce the behavior:

  1. as admin A create a user U
  2. add U and A to G
  3. impersonate U, go to contacts app
  4. create address book 1 ; leave default address book ("Contacts" of U) (referred-to as 2 here)
  5. share 1 and 2 to G (writable)
  6. "logout" (back to A), go to contacts app
  7. in contacts settings, try to rename 1 or 2

Expected behavior
The renaming should be possible to have "local" address book names.

Actual behavior
A toast message appears top right informing the user that the renaming was unsuccessful.

Server configuration

NC22 on NGINX/MariaDB/PHP8 on Arch, contacts 4.0.6

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the shared-address-book scenario in Contacts settings using the listed users, group, writable shares, and server configuration. Trace the address-book rename flow from that screen; done means users with writable shared books can rename them without the unsuccessful toast.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, mariadb, php
Domain
backend, databases
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.