nextcloud / nextcloud/contacts
Do not check that Circles is enabled, but that front-end is enabled
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 642
- Forks
- 220
- Avg merge
- 14h 39m
- Merged PRs (30d)
- 51
Description
The Circles App should not be disabled from core, but an admin can still disable some functionality like allowing its users to create their Circles.
The Capabilities from the Circles App returns if the admin disabled of not the front-end:
{
"version": "22.0.1",
"status": {},
"settings": {
"frontendEnabled": true,
[...]
},
Right now, if the frontend is disabled, creating/managin a Circle from the Contacts App will returns error
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing the Contacts App code that checks whether Circles is enabled when creating or managing a Circle, then compare that check with the Circles capabilities response and its frontendEnabled setting. Done means Contacts allows the operation when Circles is enabled but its front end is disabled, while still respecting the front-end setting.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100