nextcloud / nextcloud/contacts
Circle.basedOn is an optional parameter
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 642
- Forks
- 220
- Avg merge
- 14h 39m
- Merged PRs (30d)
- 51
Description
In some case, Circle.basedOn can be empty; the front-end is expecting basedOn(to get the Source) and will fail to display the members list if one of the Circles-as-members have no basedOn.
Case Example:
- GlobalScale setup,
- instanceB generate a Local Only Circle,
- instanceA generate a normal Circle,
- owner add a member of instanceB and set it moderator,
- moderator from instanceB add the Local Only Circle,
- getMembers on instanceA fail t displays all members
From instanceA's point of view, the Local Only Circle must be considered as a (generic) Circle, there is no real need to know/display the source at this point.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing the getMembers response and the front-end handling of Circle.basedOn, then reproduce the GlobalScale scenario with a Local Only Circle used as a member. The fix is complete when a missing basedOn is treated as a generic Circle and the members list still displays.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- api, frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100