nextcloud / nextcloud/contacts
leap day birthdays forgotten in non leap years
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 642
- Forks
- 220
- Avg merge
- 14h 39m
- Merged PRs (30d)
- 51
Description
Describe the bug
🎉 Never forget a birthday! You can sync birthdays and other recurring events with your Nextcloud Calendar.
Nextcloud does not generate birthdays in non leap years for contacts born on February 29th, causing me to miss it :(
To Reproduce
Steps to reproduce the behavior:
- Set a contacts birthday to Feb 29th 2000
- Check the calendar for Feb 28 on any non leap year
Expected behavior
The birthday should be displayed on Feb 28th or March 1st, preferably the former. Maybe also include a note about the leap year thing.
Actual behavior
There is no entry at all for non leap years.
Server configuration
Operating system: Ubuntu 20.04
Web server: Nginx
Database: MariaDB
PHP version: 7.4.3
Nextcloud version: 20.0.8
Contacts version: 3.4.3
Updated from an older Nextcloud or fresh install: Yes
Signing status:
No errors have been found.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the issue with a contact birthday of February 29, 2000, then trace the code path that generates birthday entries for the Nextcloud Calendar. Confirm the behavior in a non-leap year and consider the expected February 28 placement; done means the birthday appears there, optionally with a leap-year note.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100