nextcloud / nextcloud/contacts
Imported Google Contacts adds "\" before a "," within a phone number (Please support the "," character)
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 642
- Forks
- 220
- Avg merge
- 14h 39m
- Merged PRs (30d)
- 51
Description
Hi there,
I have a voice over IP provider whom I call locally to make international calls.
So I have setup in my contacts a "," which causes a 2 second pause so my VOIP provider can recieve the number I actually wish to call. for example the VOIP number is +99 1 5551212 and the number I wish to call is +1 202 555 1212. Therefore the contact uses the following number
+9915551212,0012025551212
The imported contact instead now has
+9915551212\,0012025551212
this "\" character is often used in PHP and HTML as a breakout character in coding and certainly should not be present within the telephone number for each imported contact.
the comma is an appropriate character for a telephone number within an addressbook
I cannot know how each implementation of my contacts will interpret this added character "\" it is not the data which should have been imported and indicates that the developer who coded the import function written in PHP does not expect a comma present within a telephone number
Nextcloud 19.0.4 Contacts 3.4.0 OS installed and updated on FreeBSD manually via CLI using the standard Nextcloud.com stable Channel
Please ping me when "," support has been added to this plugin so I can again re-import my contacts!
Thank you for the awesome work and contributions to the community!
OC
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Use the attached GoogleContactExportSamplesWithCommaInTelephoneNumber.zip as the reproduction input and compare the source phone number with the imported result. Trace the contact import path, then verify that commas are preserved without the added backslash.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100