nextcloud / nextcloud/contacts

XMPP schema

Open
#1,609 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

1. to develop bug
Dominant language
JavaScript
Stars
642
Forks
220
Avg merge
14h 39m
Merged PRs (30d)
51

Description

Describe the bug

If you add an XMPP address to a contact the resulting link is missing the xmpp: schema

To Reproduce
Steps to reproduce the behavior:

  1. Select any contact
  2. Add property of type instant messenging
  3. Select XMPP as messenger
  4. Add jid
  5. click on "open external" icon inside the input

Expected behavior
xmpp: link is rendered.

Actual behavior
https: link is rendered

Possible solution
It's probably a one line change here:
https://github.com/nextcloud/contacts/blob/b47082b0baf162be7647399276432054856b7716/src/components/Properties/PropertyText.vue#L153

Screenshots
2020-04-30 11 51 30 localhost 36a37efd80ff
2020-04-30 11 51 57 localhost 9cec6033384e

Server configuration

PHP version: 7.3

Nextcloud version: 19 beta 2

Contacts version: 3.3.0

ref nextcloud/jsxc.nextcloud#143

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in src/components/Properties/PropertyText.vue around line 153, identified in the issue. Reproduce the XMPP contact-property flow and inspect how the external link is rendered. Done means the link uses the xmpp: schema instead of https: when opening an XMPP address.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Bug
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.