nextcloud / nextcloud/contacts
Non-sharable address book shows share dialog
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 642
- Forks
- 220
- Avg merge
- 14h 39m
- Merged PRs (30d)
- 51
Description
Describe the bug
While working on https://github.com/nextcloud/server/pull/19075 I saw that for each address book the sharing icon is displayed and when you click it, you get to chose a recipient. However, some address books are not sharable. This might not apply to Nextcloud ABs, but as soon as we have ABs from apps, that might change.
To Reproduce
Steps to reproduce the behavior:
- Check out https://github.com/nextcloud/server/pull/19075
- Open Contacts
- Open settings menu
Expected behavior
No sharing icon or dialog for non-sharable ABs.
Actual behavior
Sharing for all ABs.
Screenshots
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by checking pull request 19075 and the Contacts settings menu where the sharing icon appears. Trace how address books are rendered and how the sharing dialog is opened. Done means non-sharable address books show neither a sharing icon nor a sharing dialog, while sharable address books retain the existing behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100