nextcloud / nextcloud/collectives
Guests should not create public links
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 195
- Forks
- 51
- Avg merge
- 1d 2h
- Merged PRs (30d)
- 48
Description
Is your feature request related to a problem? Please describe.
Guests can currently create public links to collections shared with them.
Describe the solution you'd like
Just as guests can no longer create collections (thank's for handling https://github.com/nextcloud/collectives/issues/2702), the creation of public links by guest users should also be prevented.
Describe alternatives you've considered
-/-
Additional context
The "deleted collections" entry in the selection of collections to be displayed should also be removed.
Thank you very much for developing the app!
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Search the guest permission checks for public-link creation and the collection selector that includes deleted collections. First trace how guest users create public links and how the selector is populated; done means guests cannot create those links and deleted collections no longer appear.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- authorization, frontend
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Active
- Clarity
- Mostly clear
- Newbie friendliness
- 55/100