nextcloud / nextcloud/client-building

MSI doesn't build when application-name has space

Open
#57 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Batchfile
Stars
40
Forks
41
Avg merge
8h 2m
Merged PRs (30d)
2

Description

Error information: "Error: SignerSign() failed." (-2146869243/0x80096005)
SignTool Error: An unexpected internal error has occurred.
"*** Sign FAILED for file: C:.../Temp/2/windows-4275/client-building/collect/Release/Win32/shellext/NCContextMenu.dll"
"*** Build FAILED: installer-collect Release Win32 (single-build-installer-collect.bat)"

Exception handling:
Error happened:

Exception: Exception
Message: build-installer-collect.bat failed. Please see log above
Code: 0
Trace: #0 C:...\brander\src\Brander\Worker\JobHandler.php(143): Brander\Worker\Desktop25WindowsJobHandler->build(Array)
#1 C:...\brander\worker\desktop-25-windows.php(30): Brander\Worker\JobHandler->run()
#2 {main}
File: C:...\Documents\brander\src\Brander\Worker\Desktop25WindowsJobHandler.php
Line: 666
CLEANUP: Try to remove temporary directories.
CLEANUP: Temporary directories removed.

PHP Notice: Undefined variable: assetURL_x86 in C:...\brander\src\Brander\Worker\Desktop25WindowsJobHandler.php on line 762
PHP Notice: Undefined variable: uploadFileName_x86 in C:...\brander\src\Brander\Worker\Desktop25WindowsJobHandler.php on line 763
PHP Notice: Undefined variable: assetURL_x64 in C:...\brander\src\Brander\Worker\Desktop25WindowsJobHandler.php on line 764
PHP Notice: Undefined variable: uploadFileName_x64 in C:...\brander\src\Brander\Worker\Desktop25WindowsJobHandler.php on line 765
INFO: Finished {
"assetURL": null,
"fileName": null,
"assetURL-x64": null,
"fileName-x64": null,
"finishedAt": 1608130708,
"logs": "...truncated..."
}
Error while running job:

Exception: GuzzleHttp\Exception\ClientException
Message: Client error: POST https://portal.nextcloud.com/brander/job/4275/finish resulted in a 413 Request Entity Too Large response
Code: 413

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with Desktop25WindowsJobHandler.php around lines 666 and 762-765, then trace the build-installer-collect.bat and single-build-installer-collect.bat entry points. Reproduce the MSI build using an application-name containing spaces; done means the Windows installer build completes without the signing failure and the reported PHP notices.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
build-system
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.