nextcloud / nextcloud/circles

Honor "shareapi_only_share_with_group_members"

Open
#381 0 comments 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
177
Forks
68
Avg merge
2d 22h
Merged PRs (30d)
60

Description

If sharing is only allowed with other members of the users group, the circles app can be used to circument the setting as it will return all users (similar to #299). This allows user to "see" other users in the system.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing how the circles app returns users when sharing is restricted by "shareapi_only_share_with_group_members". Compare that behavior with the setting described in the issue and verify that users outside the relevant group are not returned or exposed. No files or tests are named in the issue, so identify the affected lookup path and its existing coverage before changing anything.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
authorization, security
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.