Orphaned mount entries left on remote instance after deleting federated circle

How to use GitHub

• Please use the 👍 reaction to show that you are affected by the same issue.
• Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
• Subscribe to receive notifications on status change and new comments.

Deleting federated circle with shares doesn't clean up oc_circles_mount/oc_circles_mountpoint tables on remote instance.

Steps to reproduce

1. setup federation environment with two Nextcloud instances (e.g. nc_1 + nc_2)
2. on nc_1 as bob:

• create test_team and check "Allow federated members"
• add john from nc_2 (john@nc_2)
• create test_folder and share with test_team

3. on nc_2 as john:

• navigate to files > "All files" (this generates entry on oc_circles_mountpoint)

4. on nc_2 database:

MariaDB [nextcloud2]> SELECT * FROM oc_circles_mount;
+----+-----------------+---------------------------------+---------------------------------+-------+--------+--------------+----------------------------------+-----------------+-----------+
| id | mount_id        | circle_id                       | single_id                       | token | parent | mountpoint   | mountpoint_hash                  | remote          | remote_id |
+----+-----------------+---------------------------------+---------------------------------+-------+--------+--------------+----------------------------------+-----------------+-----------+
|  3 | RLNrDNoxqco3miX | vPvDgqqAe8DLTvY4UCYcUPBBpAy6rCr | Tv497OEV968gV5LAwP2UKvuKNnw9EpW |       |     -1 | /test_folder | 621df261a24cccbef218646ca800cccc | nextcloud.local |         4 |
+----+-----------------+---------------------------------+---------------------------------+-------+--------+--------------+----------------------------------+-----------------+-----------+
1 row in set (0.000 sec)

MariaDB [nextcloud2]> SELECT * FROM oc_circles_mountpoint;
+----+-----------------+---------------------------------+--------------+----------------------------------+
| id | mount_id        | single_id                       | mountpoint   | mountpoint_hash                  |
+----+-----------------+---------------------------------+--------------+----------------------------------+
|  3 | RLNrDNoxqco3miX | 1iGuQvoC19E5dkwSEXvgRvf3OXYiA3m | /test_folder | acf4921df4e099066ff9ff542447b1cd |
+----+-----------------+---------------------------------+--------------+----------------------------------+
1 row in set (0.000 sec)

• notice how entries are generated correctly

5. on nc_1 as bob

• delete test_team

6. on nc_2 as john

• navigate to files > "All files"
• notice how test_folder now longer appears there, which is correct

7. on nc_2 database:

MariaDB [nextcloud2]> SELECT * FROM oc_circles_mount;
+----+-----------------+---------------------------------+---------------------------------+-------+--------+--------------+----------------------------------+-----------------+-----------+
| id | mount_id        | circle_id                       | single_id                       | token | parent | mountpoint   | mountpoint_hash                  | remote          | remote_id |
+----+-----------------+---------------------------------+---------------------------------+-------+--------+--------------+----------------------------------+-----------------+-----------+
|  3 | RLNrDNoxqco3miX | vPvDgqqAe8DLTvY4UCYcUPBBpAy6rCr | Tv497OEV968gV5LAwP2UKvuKNnw9EpW |       |     -1 | /test_folder | 621df261a24cccbef218646ca800cccc | nextcloud.local |         4 |
+----+-----------------+---------------------------------+---------------------------------+-------+--------+--------------+----------------------------------+-----------------+-----------+
1 row in set (0.000 sec)

MariaDB [nextcloud2]> SELECT * FROM oc_circles_mountpoint;
+----+-----------------+---------------------------------+--------------+----------------------------------+
| id | mount_id        | single_id                       | mountpoint   | mountpoint_hash                  |
+----+-----------------+---------------------------------+--------------+----------------------------------+
|  3 | RLNrDNoxqco3miX | 1iGuQvoC19E5dkwSEXvgRvf3OXYiA3m | /test_folder | acf4921df4e099066ff9ff542447b1cd |
+----+-----------------+---------------------------------+--------------+----------------------------------+
1 row in set (0.000 sec)

• notice how entries are not removed, this is incorrect, should be cleaned up

Expected behaviour

when deleting a federated circle with shares, related entries on remote instances oc_circles_mount and oc_circles_mountpoint tables should be removed

Actual behaviour

when deleting a federated circle with shares, related entries on remote instances oc_circles_mount and oc_circles_mountpoint are kept there, orphaned

Server configuration

Web server: Apache/Nginx

Database: MySQL/Maria/SQLite/PostgreSQL

PHP version: 8.5/8.4/8.3

Nextcloud version: Nextcloud 36.0.0 dev

If you have access to your command line run e.g.:
sudo -u www-data php occ config:list system
from within your Nextcloud installation folder

Browser

Browser name: Firefox/Chrome/Safari/…

Browser version: 124/125/…

Operating system: Windows/Ubuntu/Mac/…

Insert your browser log here, this could for example include:
a) The javascript console log
b) The network log
c) ...

No source file or test is named. Start by tracing federated circle deletion in the circles app and the handling of oc_circles_mount and oc_circles_mountpoint on the remote instance. Reproduce the two-instance scenario and verify that both related rows are removed after the circle is deleted.