nextcloud / nextcloud/circles

Deleted or trashed folders still appear in teams view

Open
#2,408 1 comment 3 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

0. Needs triage bug
Dominant language
JavaScript
Stars
177
Forks
68
Avg merge
2d 22h
Merged PRs (30d)
60

Description

How to use GitHub
  • Please use the 👍 reaction to show that you are affected by the same issue.
  • Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
  • Subscribe to receive notifications on status change and new comments.

When a folder shared with a team is deleted or moved to the trashbin, it still appears in the Teams view. Clicking it results in a "File not found" error. This affects places that fetch and display team resources using /ocs/v2.php/teams/{circleId}/resources e. g. the Teams Files list in Contacts / Teams. For the trashbin this persists until the trash is cleared, for deleted files they are displayed until the DeleteOrphanedSharesJob cleans the shares without files.

Steps to reproduce
  1. Create a team
  2. Create a folder, share it with the team, either directly or in Contacts / Teams / Create Folder
  3. Delete the folder (optionally also empty the trashbin)
  4. The folder is still listed in Contacts / Teams in the Files list
  5. Clicking it shows "File not found"
Expected behaviour

Folders that no longer exist or are in the trashbin should not be shown in the files list.

Actual behaviour

The view lists all circle shares from the database without checking whether the underlying file is still accessible, resulting in broken entries being shown.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the /ocs/v2.php/teams/{circleId}/resources endpoint and reproduce the issue using the listed steps. Trace how team shares are fetched for the Teams Files list, including the DeleteOrphanedSharesJob behavior. Done means deleted or trashed folders are excluded and valid shared folders still appear without producing broken entries.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
api, backend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.