Misleading error message in lib/commands/CirclesCheck.php
Open
Nobody has claimed this yet.
0. Needs triage
bug
- Dominant language
- JavaScript
- Stars
- 177
- Forks
- 68
- Avg merge
- 2d 22h
- Merged PRs (30d)
- 60
Description
How to use GitHub
- Please use the 👍 reaction to show that you are affected by the same issue.
- Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
- Subscribe to receive notifications on status change and new comments.
Steps to reproduce
- Have a dysfunctional Circles config
- Run
occ circles:check - Profit!
Expected behaviour
No profit, uhm, a better error message
Actual behaviour
For debugging purposes, I extended line 287 in apps/circles/lib/Command/CirclesCheck.php: $output->writeln('<error>Event created too many Wrappers</error>: '. count($wrappers) );. The result:
root@nextcloud:~# sudo -u www-data php /var/www/nextcloud/occ -vvv circles:check
### Checking loopback address.
. The loopback setting is mandatory and can be checked locally.
. The address you need to define here must be a reachable url of your Nextcloud from the hosting server itself.
. By default, the App will use the entry 'overwrite.cli.url' from 'config/config.php'.
* testing current address: https://**redacted-address**
- GET request on https://**redacted-address**/csrftoken: 200
- POST request on https://**redacted-address**/apps/circles/async/test-dummy-token/: 200
- Creating async FederatedEvent (took 7ms)
- Waiting for async process to finish (5s)
- Checking status on FederatedEvent Event created too many Wrappers: 0
I wouldn't call zero "too many Wrappers" and neither would I go from if( count($wrappers) !== 1 ) to "oh, that's too many" but to "that's not the expected count of $wrappers" 😉.
Still can't figure out why that happens, though. But that's another issue.
Server configuration
Web server: Nginx
Database: MariaDB
PHP version: 8.4
Nextcloud version: (see Nextcloud admin page)
List of activated apps
If you have access to your command line run e.g.:
sudo -u www-data php occ app:list
from within your Nextcloud installation folder
Enabled:
- activity: 6.0.0-dev.0
- admin_audit: 1.23.0
- app_api: 33.0.0
- appointments: 2.6.3
- bruteforcesettings: 6.0.0-dev.0
- calendar: 6.2.1
- circles: 33.0.0
- cloud_federation_api: 1.17.0
- comments: 1.23.0
- contacts: 8.4.1
- contactsinteraction: 1.14.1
- cospend: 4.0.0
- dashboard: 7.13.0
- dav: 1.36.0
- deck: 1.17.0
- doom_nextcloud: 1.0.6
- federatedfilesharing: 1.23.0
- federation: 1.23.0
- files: 2.5.0
- files_downloadlimit: 5.1.0-dev.0
- files_external: 1.25.1
- files_pdfviewer: 6.0.0-dev.0
- files_reminders: 1.6.0
- files_sharing: 1.25.2
- files_trashbin: 1.23.0
- files_versions: 1.26.0
- firstrunwizard: 6.0.0-dev.0
- forms: 5.2.5
- groupfolders: 21.0.6
- impersonate: 4.0.0
- integration_mattermost: 3.0.0
- logreader: 6.0.0
- lookup_server_connector: 1.21.0
- mail: 5.7.3
- nextcloud_announcements: 5.0.0
- notes: 4.13.0
- notifications: 6.0.0
- oauth2: 1.21.0
- ownershiptransfer: 1.4.0
- password_policy: 5.0.0-dev.0
- photos: 6.0.0-dev.0
- privacy: 5.0.0-dev.0
- profile: 1.2.0
- provisioning_api: 1.23.0
- qownnotesapi: 26.2.2
- recommendations: 6.0.0-dev.0
- related_resources: 4.0.0-dev.0
- richdocuments: 10.1.0
- serverinfo: 5.0.0-dev.0
- settings: 1.16.0
- sharebymail: 1.23.0
- spreed: 23.0.1
- support: 5.0.0
- survey_client: 5.0.0-dev.0
- systemtags: 1.23.0
- tasks: 0.17.1
- text: 7.0.0-dev.3
- theming: 2.8.0
- timemanager: 0.3.23
- twofactor_backupcodes: 1.22.0
- twofactor_nextcloud_notification: 7.0.0
- twofactor_totp: 15.0.0-dev.0
- updatenotification: 1.23.0
- user_ldap: 1.24.0
- user_status: 1.13.0
- viewer: 6.0.0-dev.0
- weather_status: 1.13.0
- webhook_listeners: 1.5.0
- whiteboard: 1.5.7
- workflowengine: 2.15.0
Disabled:
- analytics: 6.1.0 (installed 6.1.0)
- carnet: 0.25.12 (installed 0.25.12)
- cookbook: 0.11.6 (installed 0.11.6)
- dashboardcharts: 0.1.3 (installed 0.1.3)
- encryption: 2.21.0
- event_update_notification: 2.8.0 (installed 2.8.0)
- external: 8.0.0 (installed 8.0.0)
- extract: 1.3.6 (installed 1.3.6)
- files_automatedtagging: 4.0.0 (installed 4.0.0)
- files_fulltextsearch: 33.0.0 (installed 33.0.0)
- files_lock: 33.0.0 (installed 33.0.0)
- files_markdown: 2.4.1 (installed 2.4.1)
- files_mindmap: 0.0.33 (installed 0.0.33)
- files_rightclick: 0.15.1 (installed 1.6.0)
- files_texteditor: 2.15.1 (installed 2.15.1)
- fulltextsearch: 33.0.0 (installed 33.0.0)
- fulltextsearch_elasticsearch: 33.0.0 (installed 33.0.0)
- keeweb: 0.6.22 (installed 0.6.22)
- ldap_write_support: 1.14.0 (installed 1.1.0)
- openotp_auth: 1.32.0 (installed 1.31.0)
- ownpad: 0.13.2 (installed 0.13.2)
- printer: 0.0.5 (installed 0.0.3)
- quicknotes: 0.8.40 (installed 0.8.40)
- richdocumentscode: 25.4.902 (installed 25.4.902)
- suspicious_login: 11.0.0-dev.0
- talk_matterbridge: 1.33.1026000 (installed 1.33.1026000)
- timetracker: 0.0.86 (installed 0.0.56)
- user_usage_report: 4.0.0 (installed 4.0.0)
- video_converter: 1.0.6 (installed 1.0.6)
- weather: 1.7.5 (installed 1.7.5)
- wopi: 3.5.11 (installed 3.5.7)
- workflow_pdf_converter: 4.0.0 (installed 4.0.0)
Nextcloud configuration
If you have access to your command line run e.g.:
sudo -u www-data php occ config:list system
from within your Nextcloud installation folder
{
"system": {
"trashbin_retention_obligation": "auto, 30",
"instanceid": "***REMOVED SENSITIVE VALUE***",
"passwordsalt": "***REMOVED SENSITIVE VALUE***",
"secret": "***REMOVED SENSITIVE VALUE***",
"trusted_domains": [
"**redacted-address**",
"**redacted-address**"
],
"datadirectory": "***REMOVED SENSITIVE VALUE***",
"overwrite.cli.url": "https:\/\/**redacted-address**",
"overwriteprotocol": "https",
"memcache.local": "\\OC\\Memcache\\Redis",
"memcache.locking": "\\OC\\Memcache\\Redis",
"redis": {
"host": "***REMOVED SENSITIVE VALUE***",
"port": 6379,
"timeout": 0,
"password": "***REMOVED SENSITIVE VALUE***"
},
"dbtype": "mysql",
"dbname": "***REMOVED SENSITIVE VALUE***",
"dbhost": "***REMOVED SENSITIVE VALUE***",
"dbport": "",
"dbtableprefix": "oc_",
"dbuser": "***REMOVED SENSITIVE VALUE***",
"dbpassword": "***REMOVED SENSITIVE VALUE***",
"version": "33.0.0.16",
"installed": true,
"ldapIgnoreNamingRules": false,
"ldapProviderFactory": "OCA\\User_LDAP\\LDAPProviderFactory",
"app_install_overwrite": {
"0": "whiteboard",
"2": "fulltextsearch",
"3": "fulltextsearch_elasticsearch",
"4": "files_fulltextsearch",
"5": "dashboardcharts",
"6": "ownpad",
"7": "timetracker",
"8": "keeweb",
"9": "documents"
},
"mail_smtpmode": "smtp",
"mail_smtphost": "***REMOVED SENSITIVE VALUE***",
"mail_sendmailmode": "smtp",
"mail_from_address": "***REMOVED SENSITIVE VALUE***",
"mail_domain": "***REMOVED SENSITIVE VALUE***",
"theme": "",
"loglevel": 1,
"has_rebuilt_cache": true,
"default_language": "de_DE",
"htaccess.RewriteBase": "\/",
"maintenance": false,
"encryption.legacy_format_support": false,
"encryption.key_storage_migrated": false,
"maintenance_window_start": 1,
"mysql.utf8mb4": true,
"serverid": 1,
"default_phone_region": "DE",
"mail_smtpport": "25",
"mail_smtpstreamoptions": {
"ssl": {
"allow_self_signed": false,
"verify_peer": true,
"verify_peer_name": true
}
},
"allow_local_remote_servers": true
}
}
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in apps/circles/lib/Command/CirclesCheck.php around line 287 and run occ circles:check with the verbose output shown in the issue. Review the condition that reports the wrapper count and update the error wording so it accurately describes an unexpected count, including zero. Done means the command no longer calls zero wrappers “too many”.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- cli
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 58/100