Allow Activity registers actions of share and unshare for circles
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 177
- Forks
- 68
- Avg merge
- 2d 22h
- Merged PRs (30d)
- 60
Description
Circles does not emit signals to actions of share and unshare, so Activity app does not register these actions.
First I tried to follow same implementation of groups, and submit changes for server and activity projects, but as recommended by @nickvergessen [1] and @rullzer in [2], I will change only Circles app, using part of signals implemented in [3], that is not integrated yet.
[1] https://github.com/nextcloud/activity/issues/269#issuecomment-388468500
[2] https://github.com/nextcloud/server/pull/9463#pullrequestreview-119621233
[3] https://github.com/nextcloud/circles/issues/163
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Review the Circles app and the signal implementation referenced in issue #163; confirm how share and unshare actions are emitted and consumed by Activity. Done means Activity registers both actions through changes limited to Circles, without changes to the server or Activity projects.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- backend
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100