Can't add LDAP group (Windows AD) into Circles
Open
Nobody has claimed this yet.
0. Needs triage
bug
- Dominant language
- JavaScript
- Stars
- 177
- Forks
- 68
- Avg merge
- 2d 22h
- Merged PRs (30d)
- 60
Description
How to use GitHub
- Please use the 👍 reaction to show that you are affected by the same issue.
- Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
- Subscribe to receive notifications on status change and new comments.
Steps to reproduce
- Go to Circles
- Add selected LDAP group into Circle
- Fail miserably :D
- Group is marked as Added, but memeber don't actually see it being in it...
Expected behaviour
LDAP group should be added to the Circle
Server configuration
Web server: Apache behind Ngnix Proxy Manager
Database: PostgreSQL
PHP version: 8.3
Nextcloud version: 30.0.2 (Nextcloud AIO 10.0.0)
List of activated apps
If you have access to your command line run e.g.:
sudo -u www-data php occ app:list
from within your Nextcloud installation folder
Nextcloud configuration
If you have access to your command line run e.g.:
sudo -u www-data php occ config:list system
from within your Nextcloud installation folder
Browser
Browser name: Firefox/Chrome/Safari/…
Browser version: 124/125/…
Operating system: Windows/Ubuntu/Mac/…
Browser log
Insert your browser log here, this could for example include:
`FederatedItemBadRequestException
Cannot add Circle as its own Member
/var/www/html/apps/circles/lib/FederatedItems/MassiveMemberAdd.php
Line 51
OCA\Circles\FederatedItems\SingleMemberAdd->generateMember(
{
"__class__": "OCA\\Circles\\Model\\Federated\\FederatedEvent"
},
{
"__class__": "OCA\\Circles\\Model\\Circle"
},
{
"__class__": "OCA\\Circles\\Model\\Member"
}
)
/var/www/html/apps/circles/lib/Service/FederatedEventService.php
Line 158
OCA\Circles\FederatedItems\MassiveMemberAdd->verify(
{
"__class__": "OCA\\Circles\\Model\\Federated\\FederatedEvent"
}
)
/var/www/html/apps/circles/lib/Service/MemberService.php
Line 256
OCA\Circles\Service\FederatedEventService->newEvent(
{
"__class__": "OCA\\Circles\\Model\\Federated\\FederatedEvent"
}
)
/var/www/html/apps/circles/lib/Controller/LocalController.php
Line 262
OCA\Circles\Service\MemberService->addMembers(
"tPCkHXzcXJLR8nkjYpGOeOUz1lP9WMf",
[
{
"__class__": "OCA\\Circles\\Model\\FederatedUser"
}
]
)
/var/www/html/lib/private/AppFramework/Http/Dispatcher.php
Line 208
OCA\Circles\Controller\LocalController->membersAdd(
"tPCkHXzcXJLR8nkjYpGOeOUz1lP9WMf",
[
{
"id": "tPCkHXzcXJLR8nkjYpGOeOUz1lP9WMf",
"type": 16
}
]
)
/var/www/html/lib/private/AppFramework/Http/Dispatcher.php
Line 114
OC\AppFramework\Http\Dispatcher->executeController(
{
"__class__": "OCA\\Circles\\Controller\\LocalController"
},
"membersAdd"
)
/var/www/html/lib/private/AppFramework/App.php
Line 161
OC\AppFramework\Http\Dispatcher->dispatch(
{
"__class__": "OCA\\Circles\\Controller\\LocalController"
},
"membersAdd"
)
/var/www/html/lib/private/Route/Router.php
Line 302
OC\AppFramework\App::main(
"OCA\\Circles\\Controller\\LocalController",
"membersAdd",
{
"__class__": "OC\\AppFramework\\DependencyInjection\\DIContainer"
},
{
"circleId": "tPCkHXzcXJLR8nkjYpGOeOUz1lP9WMf",
"_route": "ocs.circles.local.membersadd"
}
)
/var/www/html/ocs/v1.php
Line 43
OC\Route\Router->match(
"/ocsapp/apps/circles/circles/tPCkHXzcXJLR8nkjYpGOeOUz1lP9WMf/members/multi"
)
/var/www/html/ocs/v2.php
Line 7
undefinedundefinedrequire_once(
"/var/www/html/ocs/v1.php"
</details>
`Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the reported failure in apps/circles/lib/FederatedItems/MassiveMemberAdd.php at line 51 and follow the call through SingleMemberAdd.php, MemberService.php, and LocalController.php. Reproduce adding a Windows AD LDAP group to a Circle and verify that its members can see the Circle and are actually added without the reported self-member error.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php, postgresql
- Domain
- authorization, backend
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100