nextcloud / nextcloud/circles

Error when accepting an invitation from a circle you are a member of

Open
#1,598 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
JavaScript
Stars
177
Forks
68
Avg merge
2d 22h
Merged PRs (30d)
60

Description

When we are already a member of a circle and accept an invitation to the circle we get a status code 400 indicating an error with no further information, in the body of the response it is shown that a code 122 "you are already a member" is returned. It would seem friendlier to give that information and not an error, since the user expects to join a group and would be told that he was already added.

Screenshot_20240607_100231

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No files, tests, or entry points are named. Start by tracing the invitation-acceptance flow and inspect how response code 122 is handled when the requester is already a circle member. Done means this case returns the friendly already-a-member information instead of an unexplained 400 error.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
api, backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.