nextcloud / nextcloud/circles

Confidentiality and wording issues in sharing notification e-mails (when sharing with a circle)

Open
#1,239 20 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

1. to develop design enhancement
Dominant language
JavaScript
Stars
177
Forks
68
Avg merge
2d 22h
Merged PRs (30d)
60

Description

Hello,

When we receive a share from a user, because we belong to a circle, I see two problems.

The first problem is in my opinion the most annoying:
It says, for example, "John Doe shared multiple files with Marketing Team". I think that as the recipient of the share, I don't need to know the entity with which John Doe has shared the file. "Marketing team" is in my example something very classic, but the name of the circle may be quite different and have meaning only to John Doe ... and in that case, I may wonder why I am receiving this share. Just imagine also that John Doe names his circle with an "embarrassing" wording hahaha ... you know what I mean?! :-)
I think this is very important, especially if the circle is private.
So to sum up, putting the name of the circle in the notification email poses a confidentiality/privacy problem. The sentence should simply be "John Doe shared multiple files with you".

The second problem is that in all cases, it says "multiple files" in the sentence, but this is not possible because a user can only share one file at a time, or one folder at time. So the sentence should be, according to 2 possible cases :

  • "John Doe shared a file with you"
  • "John Doe shared a file with you"

Thanks for reading me.
Jérôme

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the sharing notification e-mail templates or entry points for circle shares. Check the current wording for file and folder shares and confirm the completed behavior removes the circle name, addresses the recipient directly, and uses singular wording.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.