nextcloud / nextcloud/circles

impossible to remove a member from a circle

Open
#1,219 8 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
JavaScript
Stars
177
Forks
68
Avg merge
2d 22h
Merged PRs (30d)
60

Description

Hi,
I was suggested to 'link back' here from nextcloud forum.

so, let me put it down: in circles, once a member has been added to a circle by the owner, it's impossible to remove this member. same thing for user groups or circles added to another circle.
also circles can't be deleted.
Once deleted, the page refreshed, the user or the circle are back in the list.

It's also impossible for a member to leave a group (error pop-up: impossible to leave the circle 'circlename')

This is on NC 24.0.7, Circles 24.0.1
ubuntu 22.04 apache2 maridb php8.1
safari and brave

Logging in NC:

[] Error: OCA\Circles\Tools\Exceptions\RequestNetworkException: at <>

  1. /home/apps/circles/lib/Service/FederatedEventService.php line 428
    OCA\Circles\Service\FederatedEventService->doRequest()
  2. /home/apps/circles/lib/Service/FederatedEventService.php line 182
    OCA\Circles\Service\FederatedEventService->initBroadcast()
  3. /home/apps/circles/lib/Service/CircleService.php line 489
    OCA\Circles\Service\FederatedEventService->newEvent()
  4. /home/apps/circles/lib/Controller/LocalController.php line 326
    OCA\Circles\Service\CircleService->circleLeave()
  5. /home/lib/private/AppFramework/Http/Dispatcher.php line 225
    OCA\Circles\Controller\LocalController->circleLeave()
  6. /home/lib/private/AppFramework/Http/Dispatcher.php line 133
    OC\AppFramework\Http\Dispatcher->executeController()
  7. /home/lib/private/AppFramework/App.php line 172
    OC\AppFramework\Http\Dispatcher->dispatch()
  8. /home/lib/private/Route/Router.php line 298
    OC\AppFramework\App::main()
  9. /home/ocs/v1.php line 62
    OC\Route\Router->match()
  10. /home/ocs/v2.php line 23
    require_once("/home/eve/web/l ... p")

PUT /ocs/v2.php/apps/circles/circles/7waqwsch2WN5melHT5E8aXCqU7YYEC8/leave
from 2a02:8440:4340:aced:e9a4:a25d:b0:26aa by lerez0 at 2022-11-20T17:36:40+00:00

[] Error: OCA\Circles\Tools\Exceptions\RequestNetworkException: at <>

  1. /home/apps/circles/lib/Service/FederatedEventService.php line 428
    OCA\Circles\Service\FederatedEventService->doRequest()
  2. /home/apps/circles/lib/Service/FederatedEventService.php line 182
    OCA\Circles\Service\FederatedEventService->initBroadcast()
  3. /home/apps/circles/lib/Service/CircleService.php line 489
    OCA\Circles\Service\FederatedEventService->newEvent()
  4. /home/apps/circles/lib/Controller/LocalController.php line 326
    OCA\Circles\Service\CircleService->circleLeave()
  5. /home/lib/private/AppFramework/Http/Dispatcher.php line 225
    OCA\Circles\Controller\LocalController->circleLeave()
  6. /home/lib/private/AppFramework/Http/Dispatcher.php line 133
    OC\AppFramework\Http\Dispatcher->executeController()
  7. /home/lib/private/AppFramework/App.php line 172
    OC\AppFramework\Http\Dispatcher->dispatch()
  8. /home/lib/private/Route/Router.php line 298
    OC\AppFramework\App::main()
  9. /home/ocs/v1.php line 62
    OC\Route\Router->match()
  10. /home/ocs/v2.php line 23
    require_once("/home/l ... p")

PUT /ocs/v2.php/apps/circles/circles/7waqwsch2WN5melHT5E8aXCqU7YYEC8/leave
from 2a02:8440:4340:aced:e9a4:a25d:b0:26aa by lerez0 at 2022-11-20T17:36:40+00:00

THANKS a lot if you can help

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing the PUT /ocs/v2.php/apps/circles/circles/{id}/leave endpoint through LocalController.php and CircleService.php, especially the FederatedEventService.php call at the reported lines. Reproduce the leave or removal failure and inspect the RequestNetworkException. Done means members and nested groups or circles can be removed, members can leave, and circles can be deleted without returning to the list.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
backend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.