nextcloud / nextcloud/calendar

Public holidays don't show up on sundays

Open
#6,066 10 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

0. to triage bug Feature: WebCal needs info
Dominant language
JavaScript
Stars
1.2k
Forks
332
Avg merge
16h 13m
Merged PRs (30d)
137

Description

Steps to reproduce
  1. Find a public holiday that occurs on sunday
  2. Go to the date of that holiday in the calendar
  3. Switch to week view
  4. Holiday isn't shown
Expected behavior

The holiday should appear in the calendar

Actual behaviour

The holiday doesn't appear in the calendar

Calendar app version

4.7.6

CalDAV-clients used

Nextcloud web

Browser

Brave Browser 1.67.116, Firefox 127

Client operating system

Arch Linux

Server operating system

Ubuntu Server 22.04

Web server

Apache

Database engine version

MySQL

PHP engine version

PHP 8.2

Nextcloud version

28.0.6

Updated from an older installed version or fresh install

Updated from an older version

List of activated apps
Enabled:
  - activity: 2.20.0
  - calendar: 4.7.6
  - circles: 28.0.0
  - cloud_federation_api: 1.11.0
  - comments: 1.18.0
  - contacts: 5.5.3
  - contactsinteraction: 1.9.0
  - cookbook: 0.11.0
  - dashboard: 7.8.0
  - dav: 1.29.1
  - federatedfilesharing: 1.18.0
  - federation: 1.18.0
  - files: 2.0.0
  - files_pdfviewer: 2.9.0
  - files_reminders: 1.1.0
  - files_sharing: 1.20.0
  - files_trashbin: 1.18.0
  - files_versions: 1.21.0
  - firstrunwizard: 2.17.0
  - forms: 4.2.4
  - groupfolders: 16.0.6
  - health: 2.2.2
  - integration_mastodon: 2.0.5
  - jitsi: 0.18.0
  - logreader: 2.13.0
  - lookup_server_connector: 1.16.0
  - mail: 3.6.1
  - maps: 1.4.0
  - money: 0.26.1
  - nextcloud_announcements: 1.17.0
  - notes: 4.10.0
  - notifications: 2.16.0
  - oauth2: 1.16.3
  - password_policy: 1.18.0
  - photos: 2.4.0
  - privacy: 1.12.0
  - provisioning_api: 1.18.0
  - recognize: 6.1.1
  - recommendations: 2.0.0
  - related_resources: 1.3.0
  - richdocuments: 8.3.7
  - richdocumentscode: 24.4.201
  - riotchat: 0.17.2
  - serverinfo: 1.18.0
  - settings: 1.10.1
  - sharebymail: 1.18.0
  - spreed: 18.0.8
  - support: 1.11.1
  - survey_client: 1.16.0
  - systemtags: 1.18.0
  - tasks: 0.16.0
  - text: 3.9.1
  - theming: 2.3.0
  - twofactor_backupcodes: 1.17.0
  - uppush: 1.4.3
  - user_status: 1.8.1
  - viewer: 2.2.0
  - weather_status: 1.8.0
  - workflowengine: 2.10.0
Disabled:
  - admin_audit: 1.18.0
  - bruteforcesettings: 2.8.0
  - documentserver_community: 0.1.15 (installed 0.1.15)
  - encryption: 2.16.0
  - files_external: 1.20.0
  - files_rightclick: 0.15.1 (installed 1.6.0)
  - fileslibreofficeedit: 1.1.0 (installed 1.1.0)
  - officeonline: 2.1.0 (installed 2.1.0)
  - phonetrack: 0.7.7 (installed 0.7.7)
  - suspicious_login: 6.0.0
  - twofactor_totp: 10.0.0-beta.2
  - user_ldap: 1.19.0
Nextcloud configuration
{
    "system": {
        "apps_paths": [
            {
                "path": "\/snap\/nextcloud\/current\/htdocs\/apps",
                "url": "\/apps",
                "writable": false
            },
            {
                "path": "\/var\/snap\/nextcloud\/current\/nextcloud\/extra-apps",
                "url": "\/extra-apps",
                "writable": true
            }
        ],
        "supportedDatabases": [
            "mysql"
        ],
        "memcache.locking": "\\OC\\Memcache\\Redis",
        "memcache.local": "\\OC\\Memcache\\Redis",
        "redis": {
            "host": "***REMOVED SENSITIVE VALUE***",
            "port": 0
        },
        "log_type": "file",
        "logfile": "\/var\/snap\/nextcloud\/current\/logs\/nextcloud.log",
        "logfilemode": 416,
        "instanceid": "***REMOVED SENSITIVE VALUE***",
        "passwordsalt": "***REMOVED SENSITIVE VALUE***",
        "secret": "***REMOVED SENSITIVE VALUE***",
        "trusted_domains": [
            "10.0.1.152",
            "redacted for privacy",
            "nextcloud.box"
        ],
        "datadirectory": "***REMOVED SENSITIVE VALUE***",
        "dbtype": "mysql",
        "version": "28.0.6.1",
        "overwrite.cli.url": "http:\/\/10.0.1.152",
        "dbname": "***REMOVED SENSITIVE VALUE***",
        "dbhost": "***REMOVED SENSITIVE VALUE***",
        "dbport": "",
        "dbtableprefix": "oc_",
        "mysql.utf8mb4": true,
        "dbuser": "***REMOVED SENSITIVE VALUE***",
        "dbpassword": "***REMOVED SENSITIVE VALUE***",
        "installed": true,
        "maintenance": false,
        "app_install_overwrite": [
            "mindmap_app",
            "documents",
            "ocsms"
        ],
        "loglevel": 2,
        "theme": "",
        "maintenance_window_start": 1
    }
}
Web server error log

No response

Log file

No response

Browser log

No response

Additional info

Holidays on sunday do show up on my phone with the built-in calendar app even with the same public holiday calendar.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the missing Sunday holiday in the Nextcloud Calendar web app, comparing week view with the phone calendar behavior. Trace the calendar's holiday rendering and week-view entry points to find where Sunday events are omitted. Done means public holidays occurring on Sunday appear in the web calendar's week view.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend, web-dev
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.