nextcloud / nextcloud/calendar

Sharing NcSelect doesn't show difference between group and user

Open
#5,900 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

0. to triage bug Feature: Sharing
Dominant language
JavaScript
Stars
1.2k
Forks
332
Avg merge
16h 13m
Merged PRs (30d)
137

Description

Steps to reproduce
  1. Add a user and a group with the same name
  2. Try to search for the username in the edit modal
Expected behavior

image

(files share modal)

Actual behaviour

Screenshot from 2024-04-05 16-33-01

Calendar app version

main

CalDAV-clients used

No response

Browser

No response

Client operating system

No response

Server operating system

No response

Web server

None

Database engine version

None

PHP engine version

None

Nextcloud version

No response

Updated from an older installed version or fresh install

None

List of activated apps

No response

Nextcloud configuration

No response

Web server error log

No response

Log file

No response

Browser log

No response

Additional info

search-request:

{
    "ocs": {
        "meta": {
            "status": "ok",
            "statuscode": 200,
            "message": "OK"
        },
        "data": {
            "exact": {
                "users": [
                    {
                        "label": "bob",
                        "subline": "",
                        "icon": "icon-user",
                        "value": {
                            "shareType": 0,
                            "shareWith": "bob"
                        },
                        "shareWithDisplayNameUnique": "bob",
                        "status": []
                    }
                ],
                "groups": [
                    {
                        "label": "bob",
                        "value": {
                            "shareType": 1,
                            "shareWith": "bob"
                        }
                    }
                ],
                "remotes": [],
                "remote_groups": [],
                "emails": [],
                "circles": [],
                "rooms": []
            },
            "users": [],
            "groups": [],
            "remotes": [],
            "remote_groups": [],
            "emails": [],
            "lookup": [],
            "circles": [],
            "rooms": [],
            "lookupEnabled": true
        }
    }
}

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing the sharing edit modal and its NcSelect component, then inspect how the search response distinguishes users from groups. Reproduce the case with a user and group sharing the same name. Done means the selector visibly differentiates the two results, matching the files share modal behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.