nextcloud / nextcloud/calendar

closing edit-window produces entry in activity-stream, even when nothing has changed

Open
#5,202 1 comment 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

0. to triage bug Feature: Editor
Dominant language
JavaScript
Stars
1.2k
Forks
332
Avg merge
16h 13m
Merged PRs (30d)
137

Description

Steps to reproduce
  1. have a calendar
  2. open "Edit calendar"-window by clicking the pencil
  3. do nothing within the "Edit calendar"-window
  4. close the window with the "x"
  5. look into activity-stream
Expected behavior

An entry in the activity-stream should only be done if something has really changed.

Actual behaviour

The activity-stream has always an entry "You updated calendar ...", regardless if changes where made in the "Edit calendar"-window.
This is especially unpleasant if user A is sharing a calendar to many users, all of them using the Nexctloud-App. Every time A is just checking the configuration of his shared calendar by opening and closing the edit-window, he will produce a app-notification on many devices of the other users.

Calendar app version

4.3.3

CalDAV-clients used

No response

Browser

Firefox 102.6

Client operating system

Suse-Linux

Server operating system

official docker-container

Web server

None

Database engine version

None

PHP engine version

None

Nextcloud version

25.0.5

Updated from an older installed version or fresh install

Updated from an older version

List of activated apps

No response

Nextcloud configuration

No response

Web server error log

No response

Log file

No response

Browser log

No response

Additional info

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the issue in the calendar app's Edit calendar window and inspect how closing it creates the activity-stream entry. Confirm the current behavior with no changes, then verify that unchanged edits create no entry while actual calendar changes still produce one.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.