nextcloud / nextcloud/calendar
\OCA\Calendar\Service\Appointments\BookingCalendarWriter depends on Sabre
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 1.2k
- Forks
- 332
- Avg merge
- 16h 13m
- Merged PRs (30d)
- 137
Description
Expected behavior
Our app only uses its own code, or directly dependent libraries
Actual behavior
Server's 3rdparty library is used
Possible solution
- Ship another lib for the same purpose
- Ship our own, scoped version of Sabre
Calendar app
Calendar app version: v3
cc @miaulalala
additional code from https://github.com/nextcloud/calendar/pull/5339 needs refactoring too.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with OCA\Calendar\Service\Appointments\BookingCalendarWriter and inspect the additional code from calendar pull request 5339. Trace where the app uses the server's Sabre library and compare the proposed replacement or scoped-library approaches. Done means the app no longer depends directly on the server's 3rdparty library, with related code from pull request 5339 refactored as needed.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- backend
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 25/100