nextcloud / nextcloud/calendar
Add unit tests to cover busy slot combining logic
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 1.2k
- Forks
- 332
- Avg merge
- 16h 13m
- Merged PRs (30d)
- 137
Description
Followup to #3168
The free busy modal shows slots were at least one attendee is busy as grey blocks. Those blocks are combined to prevent overlapping.
This algorithm is prune to bugs and we should add some unit tests to cover it.
See https://github.com/nextcloud/calendar/pull/3168#pullrequestreview-678380059 and https://github.com/nextcloud/calendar/blob/master/src/fullcalendar/eventSources/freeBusyBlockedForAllEventSource.js
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with src/fullcalendar/eventSources/freeBusyBlockedForAllEventSource.js and the linked pull-request review to understand the busy-slot combining logic. Add unit tests that cover the combining behavior described in the issue, then run the relevant JavaScript test suite and confirm the algorithm is covered without regressions.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100