nextcloud / nextcloud/calendar
Don't show groups in share placeholder if group sharing is disabled
Open
Nobody has claimed this yet.
1. to develop
bug
Feature: Calendar list
Feature: Sharing
good first issue
Language: PHP
skill:frontend
- Dominant language
- JavaScript
- Stars
- 1.2k
- Forks
- 332
- Avg merge
- 16h 13m
- Merged PRs (30d)
- 137
Description
Steps to reproduce
- Check out nextcloud/server#25658
- Disallow sharing with groups in the sharing settings
- Open the share section on a calendar
Expected behaviour
No mention of "groups" in the placeholder.
Actual behaviour
Mention of "groups" in the placeholder.
How to fix
- Fetch the config and inject it in the initialstate service in
ViewController - add the config into
loadSettingsFromServerinCalendar.vue - get the config from the store and condition the group showing in strings in
CalendarListItemSharingSearch.vue - add some tests for good mesure
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading the sharing configuration flow in ViewController, then follow loadSettingsFromServer in Calendar.vue to CalendarListItemSharingSearch.vue. Review existing tests near these components and add coverage for group sharing enabled and disabled. Done means the share placeholder omits “groups” when group sharing is disabled and retains it when enabled.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 35/100