nextcloud / nextcloud/bookmarks

"Open all selected" does not work on folders

Open
#2,275 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
JavaScript
Stars
1.2k
Forks
189
Avg merge
5d 11h
Merged PRs (30d)
10

Description

Is your feature request related to a problem? Please describe.
I'm not sure if this is considered a bug or a feature request (possibly both), but at the moment, clicking on "Open all selected" when a single folder is selected does not open any bookmarks. I would expect that all bookmarks inside the folder be opened when I do click on it.

Describe the solution you'd like
It would also be nice for the sake of convenience to add an "Open all bookmarks" menu entry to folders, which is common in most web browsers. When I open a new browser window, it can be a bit of a hassle to click on or select each bookmark one at a time until all of them are opened (individually or with "Open all selected"). This happens a lot for the many pages that I open regularly (e.g. for work).

Describe alternatives you've considered
I don't see a "Select all bookmarks" button either; that can be another option to make "Open all selected" more viable to use, although this would still require an extra click navigating inside the folder first if selecting the folder is not an option, making it slightly more inconvenient.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the implementation of "Open all selected" and the folder menu in the JavaScript frontend, then reproduce the behavior with a folder containing bookmarks. Confirm the desired result by opening all bookmarks in a selected folder, and check whether the folder menu also provides an "Open all bookmarks" action or whether selecting all bookmarks is the intended alternative.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.