OOM When downloading chunks from external storage
Open
Nobody has claimed this yet.
- Dominant language
- PHP
- Stars
- 272
- Forks
- 37
- PR merge metrics
- No merged PRs in 30d
Description
Similar to #154 , I am seeing an OOM in ExternalStorageService when downloading chunks.
> found a local restoring point
check health status: 0 correct, 234 missing and 0 faulty files
* Downloading data/data-633695bf-1eeb-48b8-9abb-f2cb25ce43b7/00001-XBQAigzp4k4ejeS: ok
* Downloading data/data-633695bf-1eeb-48b8-9abb-f2cb25ce43b7/00002-P1lRAfjTdEdgMLN: ok
* Downloading data/data-633695bf-1eeb-48b8-9abb-f2cb25ce43b7/00003-SssVfinoaucsON4: ok
* Downloading data/data-633695bf-1eeb-48b8-9abb-f2cb25ce43b7/00004-YQdjRyRzAAORR5Z: ^C^C
^CPHP Fatal error: Allowed memory size of 1048576000 bytes exhausted (tried to allocate 139810392 bytes) in /var/www/html/custom_apps/backup/lib/Service/ExternalFolderService.php on line 296
I am running nextcloud 23.0.2 and backup 1.0.4 - I am also running this as a hotfix https://github.com/nextcloud/backup/pull/204
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the issue with the provided occ backup:point:download command, then inspect ExternalFolderService.php at line 296. Compare the behavior with issue #154 and the referenced pull request #204. Done means external chunk downloads complete without exhausting the configured PHP memory limit.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100