ExternalFolderService.php prepareStorageConfig causes error due to missing $user
Open
Nobody has claimed this yet.
- Dominant language
- PHP
- Stars
- 272
- Forks
- 37
- PR merge metrics
- No merged PRs in 30d
Description
Context https://github.com/nextcloud/backup/blob/master/lib/Service/ExternalFolderService.php on master
Change introduced with last merge throws error due to missing $user.
It seems that manipulageStorageConfig parameter $user is optional (initialized with null).
Please either replace $user by null or evaluate an appropriate value.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in lib/Service/ExternalFolderService.php and inspect prepareStorageConfig together with the manipulageStorageConfig call that supplies the missing $user. Reproduce or trace the error, then confirm the change no longer fails when the optional user value is absent.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100