Restore Points of Instance Type "external:" Has No Validation Process
Nobody has claimed this yet.
- Dominant language
- PHP
- Stars
- 272
- Forks
- 37
- PR merge metrics
- No merged PRs in 30d
Description
After working on #177 and trying to debug #166, I've discovered that the logic inside of PointService.php in the function getRPFromInstances does not implement the proper checks for an instance type of external:NN and also looks like ExternalFolderService.php doesn't have comparable verifyPoint() function to execute the checks. It also appears to lack logic to create the signature?
This leaves the archives unvalidated and marked as invalid when their status is really unknown.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with PointService.php and its getRPFromInstances function, then inspect ExternalFolderService.php for the missing comparable verifyPoint() logic. Review issues #177 and #166 for the existing context around external:NN restore points. Done means external archives are checked consistently, their signature handling is covered, and unknown validation status is no longer marked invalid.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100