nextcloud / nextcloud/appstore

New apps are published as submodules

Open
#1,641 1 comment 0 reactions 0 assignees View on GitHub
bug
Dominant language
Python
Stars
391
Forks
175
Avg merge
1d 11h
Merged PRs (30d)
25

Description

### How to use GitHub

* Please use the 👍 [reaction](https://blog.github.com/2016-03-10-add-reactions-to-pull-requests-issues-and-comments/) to show that you are affected by the same issue.
* Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
* Subscribe to receive notifications on status change and new comments.

---

### Steps to reproduce
1. Create a new app using the online app generator and download the .tar.gz file
2. Unzip the archive (e.g. `tar xzf ..../app.tar.gz`)
3. Enter the unzipped folder (e.g. `cd helloworld`)
4. Create a git repo from the (e.g. `git init .`)

### Expected behaviour
A git repo should be created, no issues be reported.

### Actual behaviour
Upon creating the new repo, I get
```
fatal: not a git repository: /home/christian/Dokumente/nextcloud-docker-dev/workspace/server/apps-extra/helloworld/../../../.git/modules/nextcloudappstore/scaffolding/helloworld
```

Looking at `.git` in the archive, it is a text file with a submodule link:
```
$ cat .git
gitdir: ../../../.git/modules/nextcloudappstore/scaffolding/helloworld
```

This comes from the fact, that the scaffolding template is inserted as a git submodule as much as I guess.

### Browser

**Browser name:** Firefox

**Browser version:** 139.0.1

**Operating system:** Archlinux

Nothing was logged during browsing the app store. No errors were present or obvious. Just the output data (tar archive) is build in a sub-optimal fashion.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.