nextcloud / nextcloud/approve_links

Enforce that only the requested user can see the request

Open
#5 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
PHP
Stars
1
Forks
1
PR merge metrics
No merged PRs in 30d

Description

How to use GitHub
  • Please use the 👍 reaction to show that you are interested into the same feature.
  • Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
  • Subscribe to receive notifications on status change and new comments.

Feature request

Which Nextcloud Version are you currently using: 31

Is your feature request related to a problem? Please describe.
When automating processes with Flow, it's sometimes necessary to get an approval by certain people. Right now, it's not possible to enforce that only a certain user can approve or disapprove.

Describe the solution you'd like
Introduce a new optional parameter to the create link endpoint, which takes a username. If a different person then the entered user opens the link, an error is shown like "You are not permitted to approve or disapprove this request". No more details should be shown (data protection -> e.g. it could be possible to automate HR processes)

Describe alternatives you've considered
Hiding the link is possible in theory, but since there's no feedback who accepted the request to the callback URIs, theoretically everyone could have approved the request.

Another alternative is getting the approval through a document, which is safer at the moment. But this creates basically useless documents, if you're only working with Tables e.g.

Additional context
Right now I'm trying to build a workflow for requesting new hardware like laptops and smartphones. This typically needs to be approved either by HR or by the head of IT. By storing the approval link in a Table, which I use to track the requests, theoretically everyone with access to that table can approve the request and there's no protocol who did it.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the create link endpoint and trace how its username parameter and approval link are handled, including the callback URIs. Done means an optional username can restrict approval or rejection to that user, while other visitors receive only the specified permission error without request details.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
authorization, security
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.