nextcloud / nextcloud/approval

doubt about approval flow

Open
#79 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement priority low
Dominant language
JavaScript
Stars
39
Forks
10
Avg merge
20m
Merged PRs (30d)
4

Description

Hi everyone!

I have a group of 5 individuals registered to approve documents. Currently, when I request document approval, if one person from the group approves it, the document is automatically considered approved, without waiting for the other 4 individuals to also approve.
Is this correct or is it a bug?

image

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the approval flow described in the issue and compare the observed one-approval behavior with the project's intended approval rules. The screenshot and issue text do not name files or tests, so first locate the approval-state entry point and its existing tests; done means the expected behavior is confirmed or the discrepancy is reproduced and covered by a test.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
backend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.