nextcloud / nextcloud/approval

disable automatic file/folder sharing + add folder path for approved/rejected files upload

Open
#372 5 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
JavaScript
Stars
39
Forks
10
Avg merge
20m
Merged PRs (30d)
4

Description

How to use GitHub
  • Please use the 👍 reaction to show that you are interested into the same feature.
  • Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
  • Subscribe to receive notifications on status change and new comments.

Feature request

Which Nextcloud Version are you currently using: (see administration page)

Nextcloud Hub 10 (31.0.10)

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is.

  • I am using the Approval app for data in Team Folders. When I create an approval request, the app will share that folder/file with approvers in read-only mode, so Team folder permissions will be overwritten by that share. The approver will lose his editing rights defined by the Team folder permissions (or any other custom rights the approver shall have per the internal process).
  • The approved version of the file/folder with files needs to be protected from unauthorized change. It is part of the Document Change Control process. It would be great to copy or transfer the approved/rejected file/folder to another folder in the Team folder that may have custom access permissions (read-only for team members and full access for the document control team).

Describe the solution you'd like
A clear and concise description of what you want to happen.

  • It would be great to have an option to disable sharing and rely only on Team folder permissions.
  • It would be great to have an option to select a folder where the app copies or transfers the approved/rejected file/folder with assigned Tags as defined by the approval process. This folder should be from one of Team folders and may have custom access permissions (read-only and upload rights for team members and full access for the document control team).

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

The alternative is to manually transfer files from the "Work in progress" folder to the "In Check" folder, and then to the "Released" folder (each folder with custom access permissions). But it is hard to force team members to follow this procedure when you have multiple team members in your project. Your app will be a big help in automating the process.

Additional context
Add any other context or screenshots about the feature request here.

Image

I would add two slider controls, as you have for removing file approval: one to disable sharing and another to activate the selection of folder path for process results upload with Approved or Rejected Tag assigned

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

The payload names no files, tests, or entry points, so start by tracing the approval flow that shares items with approvers and handles approved or rejected results. Compare its behavior with Team folder permissions and define completion around an opt-out from automatic sharing plus configurable destination folders for both outcomes, with assigned tags preserved.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
authorization, backend, cloud
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.