nextcloud / nextcloud/approval

Dont automatically share files with groups in Approval Request

Open
#344 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
JavaScript
Stars
39
Forks
10
Avg merge
20m
Merged PRs (30d)
4

Description

Feature request

Which Nextcloud Version are you currently using: (see administration page)
32.0.0

Is your feature request related to a problem? Please describe.
Im trying to implement a approval flow for the same usergroup (customers) which may not access the same folders because they should not access the other customers project. All customers have the group "customer" set. If i share PROJECTA Folder with Customer1 and PROJECTB Folder with Customer2 and request a approval in PROJECTA Folder with the flow which allows the group 'customer' to approve the file gets shared to customer 2 too. I tried implementing a new workflow but need new tags for pending, approved and dclindes state. This wont scale with many customers.

Describe the solution you'd like
Dont automatically share files within the group. Check if one user of the group has access and then leave it. It no one has access inform the requesting user.

Describe alternatives you've considered
One Flow for every customer. But that doesnt scale very well and tag usage will explode. I cant think of any other solution tbh.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

The issue names no files, tests, or entry points. Start by reproducing the approval flow with two customer users who have access to different folders, then trace where group approval causes the file to be shared. Done means approval does not expose the file to group members without access, and the requester is informed when no eligible member has access.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
authorization
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.