nextcloud / nextcloud/approval
Missing translations and sidebar buttons
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 39
- Forks
- 10
- Avg merge
- 20m
- Merged PRs (30d)
- 4
Description
In the current approval version plenty of language variables are not covered by the translations which leads to a mix of languages. So far I've noticed:
- "Waiting for your approval" as shown in the files app is not translatable (js/approval-init.js)
- the popup when you want to approve a file contains "This user requested your approval: [...]" which is not translated (js/approval-filesPlugin.js)
Also, the approve/reject buttons that were present in the sidebar are now gone which I find quite annoying as you now have to open a PDF, read it, then close it again, right click the file or use the new selector in the files app. Is this intended?
Otherwise I really like the new approved/rejected column in the files app.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with js/approval-init.js and js/approval-filesPlugin.js to trace the two untranslated strings. Then inspect the sidebar code and approval controls to compare the current behavior with the reported missing approve/reject buttons. Done means the reported translation gaps and sidebar-button behavior are addressed or clearly confirmed as intentional.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend, internationalization
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100