nextcloud / nextcloud/approval
Approval creates "duplicate" shared file when using groupfolders
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 39
- Forks
- 10
- Avg merge
- 20m
- Merged PRs (30d)
- 4
Description
I wanted to ask for approval for a file, which exists in a groupfolder. Both requester and approver already have access to the file. Asking for approval creates a direct share, so the approver sees the file twice (once in the groupfolder and once as a shared file). I would not expect this additional share to show up for the approver.
If more elaboration on this problem is needed, please let me know!
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No files, tests, or entry points are named. Start by tracing approval requests for files in groupfolders and where the direct share is created; compare the existing groupfolder access before creating it. Done means an approver with access through the groupfolder sees the file only once, while approval still works.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100