nextcloud / nextcloud/android

CheckAvailableSpaceTask Javadoc does not match implementation.

Open
#7,876 6 comments 0 reactions 0 assignees View on GitHub
approved bug technical debt
Dominant language
Kotlin
Stars
5.6k
Forks
2k
Avg merge
2d 18h
Merged PRs (30d)
92

Description

Hi,

I noticed that the Javadoc of the doInBackground method in the CheckAvailableSpaceTask class does not match it's implementation:

https://github.com/nextcloud/android/blob/552958c886b12f1997e13252041c570bb4c5453f/src/main/java/com/owncloud/android/ui/asynctasks/CheckAvailableSpaceTask.java#L52-L68

While the comment states the params decide if the storage calulation should be done, the function simply ignores the params.
What is the expected behaviour here? What the comment says or what the code does?
Depending on that, either the comment or the code should be fixed.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.