Activity or context shall not be passed to the CloudClient constructor
Open
enhancement
needs review
technical debt
- Dominant language
- Kotlin
- Stars
- 5.6k
- Forks
- 2k
- Avg merge
- 2d 18h
- Merged PRs (30d)
- 92
Description
1. OwnCloudClientFactory.createOwnCloudClient takes **Activity** as second parameter.
This could be a problem of having _memory leaks_. e.g. OkHttp lib is pure java and does not have any link to the android app context. Could you do the same?
2. I am wondering how did you do the Unit Tests? It is harder to test having links to Android components. It would be simple having pure java unit tests.
Contributor guide
Assessment
This issue has not been assessed yet.