nextcloud / nextcloud/android

Set timeouts instead of using defaults in connectivity checks

Open
#2,473 2 comments 0 reactions 0 assignees View on GitHub
connectivity enhancement needs review
Dominant language
Kotlin
Stars
5.6k
Forks
2k
Avg merge
2d 18h
Merged PRs (30d)
92

Description

default timeouts appear to be 60 sec

https://github.com/nextcloud/android-library/blob/70f0f44500a0ac14822b4723104cfd3f21572e08/src/com/owncloud/android/lib/common/OwnCloudClientFactory.java#L55

https://github.com/nextcloud/android-library/blob/70f0f44500a0ac14822b4723104cfd3f21572e08/src/com/owncloud/android/lib/common/OwnCloudClientFactory.java#L52

I think it would make sense to set shorter timeouts for connection checks like in this case...

https://github.com/nextcloud/android/blob/1cbee0e903e2cc7ef22cf417ae8cd537dbb97677/src/main/java/com/owncloud/android/utils/ConnectivityUtils.java#L69

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.