nextcloud / nextcloud/android

Changing settings does not affect already queued upload jobs

Open
#2,018 11 comments 2 reactions 1 assignee Claimed by @mario View on GitHub
approved enhancement feature: auto upload feature: data usage pr exists
Dominant language
Kotlin
Stars
5.6k
Forks
2k
Avg merge
2d 18h
Merged PRs (30d)
92

Description

### Actual behaviour
The preference of whether uploading should be done over only Wifi or allow mobile data is stored into every queued job, instead of getting polled from the folder preferences. If a job is already queued, it will get queued using the initial settings that were set during its creation. Any changes to the settings after that are ignored.

### Expected behaviour
-A job belonging to the autoupload of a certain folder should poll the current settings of that folder to know how to proceed, not insist on using the settings that existed during the job creation.

### Steps to reproduce
-Have the Camera folder set to autoupload using Wifi only.
-Turn off Wifi
-Take a bunch of photos.
-You notice they are in the queue, but waiting for Wifi to upload
-Go to Camera autoupload preferences, switch off the "wifi only" option, to allow mobile data uploads.
-The queued jobs would still wait for Wifi.
-Taking a new photo will instantly upload over mobile data. But already queued ones will wait indefinetly till Wifi is turned on.

Workaround: Move the files to a temp folder. Force rescan, all jobs will fail as files are now missing. Copy the files to their original folder (moving for some reason didn't work, does the app keep inodes or something?), the App will now recreate the upload jobs using new settings. Once upload completes, delete temp folder.

### Environment data
Android version: 7

Device model: Samsung Note 8

Stock or customized system: Stock, December security update.

Nextcloud app version: 2.0.0

Nextcloud server version: 12.0.4

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.