nextcloud / nextcloud/android

Type STRING in Database instead of INTEGER/TEXT

Open
#1,821 5 comments 0 reactions 0 assignees View on GitHub
enhancement feature: sync technical debt
Dominant language
Kotlin
Stars
5.6k
Forks
2k
Avg merge
2d 18h
Merged PRs (30d)
92

Description

AndroidStudio suggests not to use STRING as this type can truncate leading zeros, instead Integer or Text should be used.
As this is done on upgrade from very old databases or on new installation I guess we can change this without side-effects.
Is FILESYSTEM_SYNCED_FOLDER_ID integer only? Or should we use text?

https://github.com/nextcloud/android/blob/f9983558c97bd0ef61158b9dc93ab89d20e60e2a/src/main/java/com/owncloud/android/providers/FileContentProvider.java#L1363

@mario as you wrote the code and probably know best

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.