RC 34.1.0-01: Duplicated wording in creation menu — "New" prefix + creator name produces "New New document" ("Neu Neues Dokument")
- Dominant language
- Kotlin
- Stars
- 5.6k
- Forks
- 2k
- Avg merge
- 2d 18h
- Merged PRs (30d)
- 92
Description
### ⚠️ Before posting ⚠️
- [x] This is a **bug**, not a question or an enhancement.
- [x] I've [searched for similar issues](https://github.com/nextcloud/android/issues) and didn't find a duplicate.
- [x] I've written a clear and descriptive title for this issue, not just "Bug" or "Crash".
- [x] I agree to follow Nextcloud's [Code of Conduct](https://nextcloud.com/contribute/code-of-conduct/).
### Steps to reproduce
1. Nextcloud 34.0.1 server with an ONLYOFFICE-based connector (reproduced with EuroOffice connector 11.0.1 and official ONLYOFFICE connector 10.1.2).
2. Android app RC 34.1.0-01, German locale.
3. Files view → tap "+" ("Hinzufügen zu Nextcloud").
### Expected behaviour
Either use the server-provided label as-is ("Neues Dokument"), or apply the prefix only to bare type names ("Textdokument" → "Neu: Textdokument"). A separator ("Neu: …") would also avoid the duplication gracefully for languages where the label already contains "New".
### Actual behaviour
Menu entries read (German):
- "Neu Neues Dokument"
- "Neu Neue Tabelle"
- "Neu Neue Präsentation"
- "Neu Textdokument"
- "Neu Whiteboard"
The connector's template-type labels are already full names ("Neues Dokument" = "New document"), and the app prepends its own "Neu"/"New" prefix, resulting in "New New document".
### Android version
16
### Device brand and model
Samsung Galaxy S25+
### Stock or custom OS?
Stock
### Nextcloud android app version
34.0.1
### Nextcloud server version
34.0.1
### Using a reverse proxy?
Yes
### Android logs
_No response_
### Server error logs
```bash
```
### Additional information
## Code pointer
The duplication comes from `OCFileListBottomSheetDialog.kt`, where the button label for Direct Editing creators is built as:
```kotlin
val buttonText = String.format(
fileActivity.getString(R.string.editor_placeholder),
fileActivity.getString(R.string.create_new),
creator.name
)
```
`create_new` ("New"/"Neu") is prepended to the server-provided `creator.name`, which for the ONLYOFFICE-based connectors is already a full phrase ("Neues Dokument" = "New document") — producing "Neu Neues Dokument" / "New New document". (Unchanged between stable-34.0.1 and rc-34.1.0-01; the RC's rework of `checkTemplateVisibility()` correctly hides the previously broken static template entries, thanks for that.)
- Connectors: EuroOffice 11.0.1 / ONLYOFFICE 10.1.2 — wording issue identical with both
- Locale: de_DE / de_AT
Happy to provide screenshots of both stable and RC menus.
A pull request with a proposed fix follows.
Contributor guide
Research direction
Start in OCFileListBottomSheetDialog.kt at the Direct Editing creator buttonText construction, then inspect the related create_new and editor_placeholder strings. Reproduce the Files view menu with the ONLYOFFICE-based connector in German and confirm the resulting labels no longer duplicate the server-provided creator name, while bare type names still receive the intended prefix.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- kotlin
- Domain
- mobile
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Quiet
- Clarity
- Clearly specified
- Newbie friendliness
- 85/100