nextcloud / nextcloud/android

Leaving share is not the same as deleting a file

Open
#15,496 17 comments 2 reactions 2 assignees Claimed by @mpivchev View on GitHub
enhancement feature: files
Dominant language
Kotlin
Stars
5.6k
Forks
2k
Avg merge
2d 18h
Merged PRs (30d)
92

Description

### ⚠️ Before posting ⚠️

- [x] This is a **bug**, not a question or an enhancement.
- [x] I've [searched for similar issues](https://github.com/nextcloud/android/issues) and didn't find a duplicate.
- [x] I've written a clear and descriptive title for this issue, not just "Bug" or "Crash".
- [x] I agree to follow Nextcloud's [Code of Conduct](https://nextcloud.com/contribute/code-of-conduct/).

### Steps to reproduce

1. Select a shared file
2. Try to delete this file: it shows "Leave this share" instead of deleting

It is unclear what "Leaving this share" means. It is semantically different from deleting a file.

(Introduced by commit https://github.com/nextcloud/android/commit/f788112ddd2aaca591e5d9febf20bba26529e7a9)

### Expected behaviour

I want to delete a shared file.

### Actual behaviour

It does in fact delete the file but it's not clear from the text, if this is intentional.

### Android version

15

### Device brand and model

Fairphone 6

### Stock or custom OS?

Stock

### Nextcloud android app version

3.33.0 RC2

### Nextcloud server version

Nextcloud Hub 10 (31.0.8)

### Using a reverse proxy?

Yes

### Android logs

_No response_

### Server error logs

```bash

```

### Additional information

_No response_

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.