nextcloud / nextcloud/android

Error allows re-sharing in the sharing feature.

Open
#14,287 2 comments 0 reactions 1 assignee Claimed by @tobiasKaminsky View on GitHub
bug
Dominant language
Kotlin
Stars
5.6k
Forks
2k
Avg merge
2d 18h
Merged PRs (30d)
92

Description

### ⚠️ Before posting ⚠️

- [x] This is a **bug**, not a question or an enhancement.
- [x] I've [searched for similar issues](https://github.com/nextcloud/android/issues) and didn't find a duplicate.
- [x] I've written a clear and descriptive title for this issue, not just "Bug" or "Crash".
- [x] I agree to follow Nextcloud's [Code of Conduct](https://nextcloud.com/contribute/code-of-conduct/).

### Steps to reproduce

Step 1: Open the details of the folder/file.
Step 2: Select the "Sharing" tab.
Step 3: Share permissions with the specified user.
Step 4: Select permissions in the "Share Permissions" section and also check "Allow re-sharing" in the advanced options.

### Expected behaviour

"Allow re-sharing" is an advanced option and does not affect the permissions already selected in the "Share Permissions" section.

### Actual behaviour

the "Allow re-sharing" permission is presented as an advanced option.
However, in the code logic, if the "Allow re-sharing" permission is selected, all other permissions under "Share permissions" are ignored.

### Android version

13

### Device brand and model

Samsung

### Stock or custom OS?

Stock

### Nextcloud android app version

3.30.6

### Nextcloud server version

30300690

### Using a reverse proxy?

I don't know

### Android logs

_No response_

### Server error logs

```bash

```

### Additional information

I noticed that if the "Allow re-sharing" option is "isChecked," other permissions are ignored.
https://github.com/nextcloud/android/blob/cf533cdcec11256ced9ca8ae3fde24c66ad9d680/app/src/main/java/com/owncloud/android/ui/fragment/FileDetailsSharingProcessFragment.kt#L551
![Image](https://github.com/user-attachments/assets/9268aadd-8be0-4c3e-8f33-bde9af5d3070)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.