nextcloud / nextcloud/android

StrictMode warning & potential ANR problem with fixStoragePath()

Open
#10,126 0 comments 0 reactions 0 assignees View on GitHub
approved enhancement hotspot: device storage performance: misc technical debt
Dominant language
Kotlin
Stars
5.6k
Forks
2k
Avg merge
2d 18h
Merged PRs (30d)
92

Description

### Steps to reproduce
MainApp.fixStoragePath() checks SD card (if present) which can be potentially slow.
I propose we put this initialization in a thread. This will improve app start and decrease likelihood of ANR.
I have prepared a patch and will make a PR.

### Expected behaviour
This is an improvement, not a bug. App works great without it.

### Actual behaviour

### Can you reproduce this problem on https://try.nextcloud.com?

### Environment data
Android version:11

Device model:
moto g10

Stock or customized system:
stock

Nextcloud app version:
/master

Nextcloud server version:

Reverse proxy:

### Logs
#### Web server error log

#### Nextcloud log (data/nextcloud.log)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.