nextcloud / nextcloud/activity
If preview generation fails for a file there is no fallback mimetype icon
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 145
- Forks
- 72
- Avg merge
- 6d 9h
- Merged PRs (30d)
- 42
Description
The activity app is not very forgiving to thumbnail errors. It basically only checks if the mimetype is supported and not whether the actual preview could be generated.
I guess it should do something like:
https://github.com/nextcloud/spreed/blob/2463190ded52085a0f317dc5b057253aadaa5be4/src/components/MessagesList/MessagesGroup/Message/MessagePart/FilePreview.vue#L404-L412
_Originally posted by @nickvergessen in https://github.com/nextcloud/server/issues/36304
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the thumbnail handling in js/script.js around lines 254-257 and the related response in lib/Controller/APIv2Controller.php around lines 378-386. Compare the fallback behavior in the linked spreed FilePreview.vue example. Done means a failed preview generation displays a fallback mimetype icon instead of leaving the activity thumbnail without an icon.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, php
- Domain
- backend, frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100