nextcloud / nextcloud/activity
Wrong skipped count in digest email
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 145
- Forks
- 72
- Avg merge
- 6d 9h
- Merged PRs (30d)
- 42
Description
When generating a daily digest mail the skipped counter is not correct as the events returned might be grouped and therefore be less events then actual unfolded activity entries:
Would need some counting of child events that the GroupHelper generates: https://github.com/nextcloud/activity/blob/33a8da39b607891807cb87ae652e973617046efa/lib/GroupHelper.php#L205-L215
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in lib/DigestSender.php around lines 164-176 and trace how the skipped count is calculated for grouped events. Then inspect lib/GroupHelper.php around lines 205-215 to understand the child events it generates. Done means the digest's skipped count reflects the unfolded activity entries rather than only the grouped events.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100