nextcloud / nextcloud/activity
E-Mails ignore locale setting
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 145
- Forks
- 72
- Avg merge
- 6d 9h
- Merged PRs (30d)
- 42
Description
Currently, the notification e-mails sent for activities ignore the locale set by the user. Looking at the code in https://github.com/nextcloud/activity/blob/master/lib/MailQueueHandler.php#L352 the mail handler seems to only read the language and time zone of the user but not the locale for date-time formatting.
Steps to reproduce
- Set language to "English"
- Set locale to "Germany"
- Expect an e-mail in English language with German date/time formatting (24h)
Expected behaviour
Receive an e-mail in English language with proper 24h time format from "Germany" locale
Actual behaviour
Receive an e-mail in English language with 12h time format (AM/PM)
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at lib/MailQueueHandler.php around line 352, where the notification mail handler reads the user’s language and time zone. Reproduce with English language and Germany locale, then verify that the email uses English text and German 24-hour date/time formatting; done when the observed output matches the expected behaviour.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- backend, localization
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100